<< | Thread Index | >> ]    [ << | Date Index | >> ]

Subject: Re: last patch is too much drastic?
From: Johannes Reisinger <Johannes.Reisinger,AT,frequentis,DOT,com>
Date: Wed, 23 Jan 2002 14:19:08 +0100
In-reply-to: <3C4D4CE0.A867094B@bigfoot.com>

Hi!

I believe I have found the reason of the error.
The given patch ensured that 'length' is greater or equal to 'cipehdrlen'
(plus some socket info in case socks is used). But 'cipehdrlen'
included the sizes of the IP and UDP headers while 'length' does
not.

Therefore I suggest to apply the following patch (onto the patched sources):

#### Patch data follows ####
diff -c 'cipe/cipe/sock.c' 'cipe-patched/cipe/sock.c'
Index: ./cipe/sock.c
Prereq:  1.33.2.1 
*** ./cipe/sock.c       Wed Jan 16 04:55:34 2002
--- ./cipe/sock.c       Wed Jan 23 13:46:46 2002
***************
*** 211,217 ****
    goto framerr;
      }
  #endif
!     if (length<cipehdrlen+(c->sockshost?sizeof(struct sockshdr):0)) {
          printk(KERN_INFO "%s: got short packet from %s\n", c->dev->name,
                 cipe_ntoa(saddr(skb)));
         goto framerr;
--- 211,218 ----
    goto framerr;
      }
  #endif
!     if (length<cipehdrlen-sizeof(struct iphdr)-sizeof(struct udphdr)
!                          +(c->sockshost?sizeof(struct sockshdr):0)) {
          printk(KERN_INFO "%s: got short packet from %s\n", c->dev->name,
                 cipe_ntoa(saddr(skb)));
         goto framerr;
#### End of Patch data ####

On Wed, Jan 23, 2002 at 09:55:53AM +0100, Johannes Reisinger wrote:
> 
> Hi Marco!
> 
> I have exactly the same problem when I applied the patch. My setup is very
> similar to yours:
> 
> I connect a Win-2000 Box running CIPE-Win32-2.0-pre9 with a dynamic IP
> address to a Linux box running cipe-1.5.2 with the latest patch. I get
> every 10 seconds the kernel log message:
> 
>    Jan 22 01:22:34 wall kernel: cipcb0: got short packet from 193.154.7.241
> 
> The firewall logging tells me that it receives packets with length 44 from
> the cipcb0 interface.
> 
> Maybe this problem is specific to the Windows - Linux setup? Does anyone
> see this behaviour too? Maybe with a different setup?
> 
> -jr
> 
> On Tue, Jan 22, 2002 at 12:28:32PM +0100, Marco Palumbi wrote:
> > 
> > Its only few days I am using CIPE.
> > It seems to me that the patch cut out some part of the protocol(CT_PING
> > ??).
> > With CIPE patched i also experience some more problems having the two
> > system connected.
> > Here are the daemon debug output and syslog on the linux box for both
> > CIPE 1.5.2 with and without the last patch. (crasher [IMPORTANT PATCH])
> > 
> > 
> > 
>=================================================================================
> > 
> > My system:
> > 
> >      -------    ---------                 ---------         -------
> >     |       |  |  adsl    |              |   adsl   |      |       |
> >     | WinNT |--|nat router|-- internet --|nat router|------| linux |
> >     |       |  |  Alcatel |              |  Zyxell  |      |       |
> >      -------    ----------                ----------        -------
> > 
> >                 dynamic IP
> >                  A.B.C.D
> > 
> >      WinNT 4.0                            static IP        linux kernel
> >      CIPE-Win32-2.0-pre9                  port 8005          2.2.16
> >                                        exported to linux    cipe-1.5.2
> > 
> > 
>=====================================================================================
> > 
> > CIPE 1.5.2 with last patch applied
> > 
> > [...]
> 
> --
> Message sent by the cipe-l,AT,inka,DOT,de mailing list.
> Unsubscribe: mail majordomo,AT,inka,DOT,de, "unsubscribe cipe-l" in body
> Other commands available with "help" in body to the same address.
> CIPE info and list archive: 
><URL:http://sites.inka.de/~bigred/devel/cipe.html>





<< | Thread Index | >> ]    [ << | Date Index | >> ]